enhance: [2.5] Add try-catch and return CStatus for NewCollection (#39279) #39303
+203
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o#39279) Related to milvus-io#28795 Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39303 +/- ##
==========================================
+ Coverage 81.02% 81.04% +0.01%
==========================================
Files 1400 1401 +1
Lines 197477 197222 -255
==========================================
- Hits 160013 159831 -182
+ Misses 31840 31771 -69
+ Partials 5624 5620 -4
|
Related to previous pr milvus-io#39279 When NewCollection returns nil, the error shall be returned and handled by caller Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
added
size/L
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from master
pr: #39279
Related to #28795